New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sunburst - datalabels draw incorrectly #8502

Closed
sebastianbochan opened this Issue Jun 20, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@sebastianbochan
Contributor

sebastianbochan commented Jun 20, 2018

Actual behaviour

  • overlapping labels in the center of circle
  • when we click i.e on equity, label from the first level is still visible
  • when we click i.e on equity and get back to initial state, more labels are visible

Live demo with steps to reproduce

Product version

6.1

Affected browser(s)

All

@jon-a-nygaard

@TorsteinHonsi

This comment has been minimized.

Collaborator

TorsteinHonsi commented Jun 21, 2018

The labels should probably not be rotated at all for the center slices. We should come up with some algorithm as to when we want to rotate them.

For example

  • When the inner arc is 0 and the outer arc is greater than the radius, rotation makes little sense.
  • When the inner arc is not null and the outer arc is significantly greater than the radius, it may be better to rotate so that the label is tangent to the perimeter, not perpendicular like now. See "Equity" and "Dept" in the provided demo.
  • In other cases, the center labels should be skipped (or shortened) so that they don't extend all the way to the center. The outer and inner arc can be used for this.

TorsteinHonsi added a commit that referenced this issue Jun 21, 2018

Added new default behaviour for sunburst data labels, `rotationMode: …
…'auto'`. Now the best fit will be calculated. See #8502.
@TorsteinHonsi

This comment has been minimized.

Collaborator

TorsteinHonsi commented Jun 21, 2018

The commit above fixes the two first bullet points.

The last one is not related I think, it has to do with what levels are rendered, rather than what labels. See #8504.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment