New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using chart.update to update series data/nodes for SANKEY results in appended instead of replaced node/dataLabel elements #8682

Closed
enderton opened this Issue Jul 26, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@enderton

enderton commented Jul 26, 2018

Expected behaviour

If using chart.update to update the series data and nodes for a sankey, both the links and node displays (including labels) are properly updated (removed/replaced as appropriate)

Actual behaviour

The links are properly updated with new options, with one accurate set of link paths; however for the nodes, including the labels for them, instead of a single updated set, the old sets remains and a new set of nodes/label elements are appended. After multiple updates there are many duplicated elements.
(In fiddle below, if inspect elements can see each time hit 'update' button, additional elements are added in relevant groups each time)

1st fiddle most closely represents use case trying to update for (changing color of a node programatically), 2nd fiddle is one where issues is more obvious visually, as opposed to needing to inspect elements - and that even if not included nodes specifically in update body, they are not accurately updated.

Live demo with steps to reproduce

https://jsfiddle.net/nfgrectj/43/
https://jsfiddle.net/nfgrectj/46/

Product version

Highcharts 6.1.1

Affected browser(s)

Presumably all, but confirmed issue in
Chrome 67.0.3396.99
Firefox 61.0.1 (64-bit)
Safari 11.1.2 (12605.3.8.1)

@sebastianbochan

This comment has been minimized.

Show comment
Hide comment
@sebastianbochan

sebastianbochan Jul 26, 2018

Contributor

Hi @enderton,
Thank you for the reporitng.

Internal note
chart.series[0].update() does not work too.
Demo:

Contributor

sebastianbochan commented Jul 26, 2018

Hi @enderton,
Thank you for the reporitng.

Internal note
chart.series[0].update() does not work too.
Demo:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment