If specified the "column" for each node, the links between nodes are not drawn correctly

[zlateskud]

Hello,

We have a problem with the sankey diagram.

If specified the "column" for each node, the links between nodes are not drawn correctly.
Besides that, in Internet Explorer 11 compatibility mode 7, using oldie.js the graphic isn't showing at all if is specified the column. Without it everything looks ok.

In attachment you find the code example

Some images on different browsers:
1)With no colun in Chrome

2)With no colun in IE11/CM7

3)Column specified in Chrome

4)Column specified in IE11/CM7

Live demo with steps to reproduce

http://jsfiddle.net/0j8hds9u/4/

Product version

Highcharts JS v6.1.1 (2018-06-27)

Affected browser(s)

Chrome 68 and IE11 Compatibility mode 7

Thank you.

[KacperMadej]

Hi @zlateskud

Thank you for reporting about the bug.

After debugging in IE7 looks like there's a problem with forEachPolyfill.
It should:

executes the provided callback once for each element present in the array in ascending order. It is not invoked for index properties that have been deleted or are uninitialized

but it runs for all array indexes from 0 to length-1

		    H.forEachPolyfill = function (fn, ctx) {
		        var i = 0,
		            len = this.length;
		        for (; i < len; i++) {
		            if (fn.call(ctx, this[i], i, this) === false) {
		                return i;
		            }
		        }
		    };

As a workaround:

use this code after loading oldie module, but before creating any charts:

Highcharts.forEachPolyfill = function (fn, ctx) {
    var i = 0,
        len = this.length;
    for (; i < len; i++) {
        if (
            this[i] !== undefined && // added check
            fn.call(ctx, this[i], i, this) === false
        ) {
            return i;
        }
    }
};

[zlateskud]

Hi @KacperMadej ,
this solves the problem in IE11/CM7, but remain the problem with the column.
If specified the "column" for each node, the links between nodes are not drawn correctly.

Thank you.

[pawelfus]

@TorsteinHonsi fyi

[TorsteinHonsi]

I think the problem with the badly drawn columns is that you start by assigning nodes to column 1, and there are not nodes assigned to column 0. When starting from 0, it looks correct: http://jsfiddle.net/highcharts/0j8hds9u/18/

[tynorton]

This change appears to have broken our column chart plotlines.

Is there a case tracking this regression?

[KacperMadej]

@tynorton Are you sure this is caused by the fix of this issue? Please create a live demo and add more info about used browser.

[tynorton]

Maybe not this issue, definitely part of 6.1.4.

[keeslinp]

I think 6.1.4 broke stuff for us as well. Our tests started failing with an error m.getSpanWidth is not a function in highcharts. highcharts is a transitive dependency of react-highcharts which doesn't have its dependencies locked down so we were updated unexpectedly.

[KacperMadej]

@keeslinp Seems to be a react-highcharts issue, so you should probably report this to the authors of that software - it's not an official react wrapper. Without a live demo there's nothing for us to debug, identify and fix, so please provide a way for us to work with a demo showing the problem.

[keeslinp]

Sounds good, I'll report it to them. It is worth noting though that forcing high charts back down a version fixes the problem.

…

On Thu, Sep 27, 2018, 2:03 AM Kacper Madej ***@***.***> wrote: @keeslinp <https://github.com/keeslinp> Seems to be a react-highcharts issue, so you should probably report this to the authors of that software - it's an official react wrapper. Without a live demo there's nothing for us to debug, identify and fix, so please provide a way for us to work with a demo showing the problem. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8865 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC6-bAv-rZ7Z7PrXjeGqXgynA088x_U9ks5ufIZigaJpZM4WTosn> .

[TorsteinHonsi]

Our tests started failing with an error m.getSpanWidth is not a function in highcharts.

See #9058, it seems that the react tests run jsdom in the background, and jsdom doesn't support tspan.getSubStringLength.

[maljones]

@tynorton's issue looks somewhat similar to mine. Since the 6.1.4 fix, line charts have filled areas: https://www.ecosresults.org/states/alabama/. Rolling back to 6.1.3 gives the lines back there proper dimensions (although it's ignoring my series styling when I do that).

Browsers:

Chrome Mac: Version 69.0.3497.100 (Official Build) (64-bit)
Firefox Mac: 62.0
Client reported it on iOS Safari: Unsure which version

[KacperMadej]

Hi @maljones

If you would like to report a bug please open a new issue - your last comment doesn't look like related to the original issue reported here, so it would be more readable if it were a separate issue. If you have a problem, but are not sure if it's a bug please contact technical support first to confirm - https://www.highcharts.com/support