New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed two exceptions thrown when some Points are destroyed but the Se… #5197

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@pmalouin

pmalouin commented Apr 8, 2016

…ries is not yet redrawn.

My code calls series.setData(data, false) and waits a few milliseconds before calling redraw(). setData() destroys all points in series.points, but leaves them in the array, and I think it causes some exceptions that happen some time to time.

The change in DataGrouping.js prevents an exception when groupedData[i].destroy equals null and I destroy() the chart.

The change in Series.js prevents an exception at Pointer.js:204 when kdpoint[0].series equals null and I hover the mouse over the chart.

I'd be happy to make adjustments if this PR is missing something. Thank you!

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Apr 11, 2016

Collaborator

Thanks! In general, we need a reproduction on jsFiddle so that we can test the code, and if possible add it as a unit test.

Collaborator

TorsteinHonsi commented Apr 11, 2016

Thanks! In general, we need a reproduction on jsFiddle so that we can test the code, and if possible add it as a unit test.

Patrick Malouin
After update to latest highcharts version v4.2.4, this change is no l…
…onger needed (destroying the chart does not throw anymore).
@pmalouin

This comment has been minimized.

Show comment
Hide comment
@pmalouin

pmalouin Apr 15, 2016

Hi, I haven't had time to produce a jsFiddle, but I tried the latest highcharts version, and the error thrown on destroy() isn't thrown anymore. I updated the pull request accordingly.
I'll try to take the time to create a jsFiddle shortly.
Thanks for the great work!

pmalouin commented Apr 15, 2016

Hi, I haven't had time to produce a jsFiddle, but I tried the latest highcharts version, and the error thrown on destroy() isn't thrown anymore. I updated the pull request accordingly.
I'll try to take the time to create a jsFiddle shortly.
Thanks for the great work!

@pmalouin

This comment has been minimized.

Show comment
Hide comment
@pmalouin

pmalouin May 6, 2016

I managed to create a simple jsfiddle for the error thrown on hover.
To reproduce, run the jsfiddle, and move the mouse over the graph. The error is thrown at highstock.src.js:10273 : Uncaught TypeError: Cannot read property 'group' of null.

pmalouin commented May 6, 2016

I managed to create a simple jsfiddle for the error thrown on hover.
To reproduce, run the jsfiddle, and move the mouse over the graph. The error is thrown at highstock.src.js:10273 : Uncaught TypeError: Cannot read property 'group' of null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment