New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use https for loading PDF library #5919

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@tomascassidy
Contributor

tomascassidy commented Nov 2, 2016

The existing http link cannot be loaded if the site using the export module is hosted on a secure https domain.

#5278

Use https for loading PDF library
The existing http link cannot be loaded if the site using the export module is hosted on a secure https domain.

#5278
@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Nov 2, 2016

Collaborator

Thanks!

Collaborator

TorsteinHonsi commented Nov 2, 2016

Thanks!

@Frank004

This comment has been minimized.

Show comment
Hide comment
@Frank004

Frank004 Nov 10, 2016

Hi, what do I need to change to get this fix?
I'm having this issue on my app.

setup

<script src="https://code.highcharts.com/highcharts.js"></script>
<script src="https://code.highcharts.com/highcharts-more.js"></script>
<script src="https://code.highcharts.com/modules/exporting.js"></script>
<script src="https://code.highcharts.com/modules/offline-exporting.js"></script>
<script src="https://code.highcharts.com/modules/drilldown.js"></script>
<script src="https://code.highcharts.com/modules/no-data-to-display.js"></script>

error

' was loaded over HTTPS, but requested an insecure script 'http://code.highcharts.com/5.0.2/lib/jspdf.js'. This request has been blocked; the content must be served over HTTPS.

Frank004 commented Nov 10, 2016

Hi, what do I need to change to get this fix?
I'm having this issue on my app.

setup

<script src="https://code.highcharts.com/highcharts.js"></script>
<script src="https://code.highcharts.com/highcharts-more.js"></script>
<script src="https://code.highcharts.com/modules/exporting.js"></script>
<script src="https://code.highcharts.com/modules/offline-exporting.js"></script>
<script src="https://code.highcharts.com/modules/drilldown.js"></script>
<script src="https://code.highcharts.com/modules/no-data-to-display.js"></script>

error

' was loaded over HTTPS, but requested an insecure script 'http://code.highcharts.com/5.0.2/lib/jspdf.js'. This request has been blocked; the content must be served over HTTPS.
@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Nov 11, 2016

Collaborator

The fix just changed the default value, you can easily override it from the settings:

Highcharts.setOptions({
    exporting: {
        libURL: 'https://code.highcharts.com/5.0.2/lib/'
    }
});
Collaborator

TorsteinHonsi commented Nov 11, 2016

The fix just changed the default value, you can easily override it from the settings:

Highcharts.setOptions({
    exporting: {
        libURL: 'https://code.highcharts.com/5.0.2/lib/'
    }
});
@Frank004

This comment has been minimized.

Show comment
Hide comment
@Frank004

Frank004 commented Nov 11, 2016

@TorsteinHonsi Thank you!

@tomascassidy tomascassidy deleted the tomascassidy:patch-2 branch Dec 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment