Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs and reorganizes modules #560

Merged
merged 7 commits into from Mar 13, 2019

Conversation

Projects
None yet
2 participants
@fedefernandez
Copy link
Collaborator

commented Feb 5, 2019

Fixes #517

It also finishes the metrics migration

@codecov

This comment has been minimized.

Copy link

commented Feb 5, 2019

Codecov Report

Merging #560 into master will decrease coverage by 2.77%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #560      +/-   ##
=========================================
- Coverage   84.87%   82.1%   -2.78%     
=========================================
  Files          71      62       -9     
  Lines        1124     950     -174     
  Branches       16      13       -3     
=========================================
- Hits          954     780     -174     
  Misses        170     170
Impacted Files Coverage Δ
.../mu/rpc/internal/interceptors/GrpcMethodInfo.scala 100% <ø> (ø) ⬆️
...kindness/mu/rpc/prometheus/PrometheusMetrics.scala 92.3% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fb3c1a...0f4bc5c. Read the comment docs.

@fedefernandez fedefernandez changed the title [WIP] - Update docs and reorganizes modules Update docs and reorganizes modules Mar 12, 2019

@juanpedromoreno
Copy link
Member

left a comment

Thanks @fedefernandez !

LGTM on green :)

@fedefernandez fedefernandez force-pushed the ff/517-metrics-modules branch from 18d9268 to 8575969 Mar 13, 2019

@fedefernandez fedefernandez merged commit ca120d9 into master Mar 13, 2019

4 checks passed

codecov/patch 100% of diff hit (target 84.87%)
Details
codecov/project Absolute coverage decreased by -2.77% but relative coverage increased by +15.12% compared to 6fb3c1a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@fedefernandez fedefernandez deleted the ff/517-metrics-modules branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.