Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some package names and some refactors #565

Merged
merged 1 commit into from Feb 20, 2019

Conversation

Projects
None yet
3 participants
@fedefernandez
Copy link
Collaborator

commented Feb 20, 2019

This PR:

  • Adds a new module that will contain the prometheus metrics impl
  • Fixes dropwizard package names
  • Moves the interceptor implicits for the server to the server module
@codecov

This comment has been minimized.

Copy link

commented Feb 20, 2019

Codecov Report

Merging #565 into master will decrease coverage by 0.07%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #565      +/-   ##
==========================================
- Coverage   84.69%   84.61%   -0.08%     
==========================================
  Files          68       69       +1     
  Lines        1065     1066       +1     
  Branches       20       15       -5     
==========================================
  Hits          902      902              
- Misses        163      164       +1
Impacted Files Coverage Δ
.../rpc/server/metrics/MetricsServerInterceptor.scala 100% <ø> (ø) ⬆️
...indness/mu/rpc/server/interceptors/implicits.scala 100% <ø> (ø)
...pc/channel/metrics/MetricsChannelInterceptor.scala 100% <ø> (ø) ⬆️
...kindness/mu/rpc/prometheus/PrometheusMetrics.scala 0% <0%> (ø)
...kindness/mu/rpc/dropwizard/DropWizardMetrics.scala 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0672374...44adb20. Read the comment docs.

@fedefernandez fedefernandez merged commit e141b65 into master Feb 20, 2019

2 of 4 checks passed

codecov/patch 50% of diff hit (target 84.69%)
Details
codecov/project 84.61% (-0.08%) compared to 0672374
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@fedefernandez fedefernandez deleted the ff/metrics-refactor branch Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.