Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC Server Start with Brackets #566

merged 2 commits into from Mar 12, 2019


None yet
3 participants
Copy link

commented Mar 2, 2019

Use F bracket on GrpcServer

@AdrianRaFo AdrianRaFo requested a review from fedefernandez Mar 2, 2019


This comment has been minimized.

Copy link

commented Mar 2, 2019

@AdrianRaFo the current implementation doesn't block the thread. The awaitTermination() does not return until the GrpcServer is shutdown() which doesn't happen until the shutdown hook. Have you checked if this is the case with this approach?


This comment has been minimized.

Copy link

commented Mar 2, 2019

Codecov Report

Merging #566 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #566      +/-   ##
+ Coverage   84.61%   84.71%   +0.09%     
  Files          69       71       +2     
  Lines        1066     1099      +33     
  Branches       15       16       +1     
+ Hits          902      931      +29     
- Misses        164      168       +4
Impacted Files Coverage Δ
...cala/higherkindness/mu/rpc/server/GrpcServer.scala 69.23% <ø> (ø) ⬆️
...c/main/scala/higherkindness/mu/http/protocol.scala 100% <0%> (ø)
.../main/scala/higherkindness/mu/http/implicits.scala 81.25% <0%> (ø)
...herkindness/mu/rpc/channel/cache/ClientCache.scala 85.71% <0%> (+3.57%) ⬆️
...c/main/scala/higherkindness/mu/MonixAdapters.scala 92.3% <0%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e141b65...b1914a2. Read the comment docs.

@juanpedromoreno juanpedromoreno changed the title Implement comment RPC Server Start with Brackets Mar 2, 2019


This comment has been minimized.

Copy link
Contributor Author

commented Mar 10, 2019

Due to bracket impl bock the thread I'm going just to delete the comment because it's not needed anymore

@AdrianRaFo AdrianRaFo merged commit 43d524f into master Mar 12, 2019

4 checks passed

codecov/patch Coverage not affected when comparing e141b65...b1914a2
codecov/project 84.71% (+0.09%) compared to e141b65
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@AdrianRaFo AdrianRaFo deleted the arf-use-bracket branch Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.