Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro Fix - Uses the F param in macro #569

Merged
merged 1 commit into from Mar 3, 2019

Conversation

Projects
None yet
2 participants
@juanpedromoreno
Copy link
Member

commented Mar 3, 2019

This PR changes the clientFromChannel method to use $F instead of F.

@juanpedromoreno juanpedromoreno requested a review from fedefernandez Mar 3, 2019

@codecov

This comment has been minimized.

Copy link

commented Mar 3, 2019

Codecov Report

Merging #569 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #569     +/-   ##
=========================================
- Coverage    84.7%   84.61%   -0.1%     
=========================================
  Files          69       69             
  Lines        1066     1066             
  Branches       15       15             
=========================================
- Hits          903      902      -1     
- Misses        163      164      +1
Impacted Files Coverage Δ
...herkindness/mu/rpc/channel/cache/ClientCache.scala 82.14% <0%> (-3.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe6df2f...462f725. Read the comment docs.

@juanpedromoreno juanpedromoreno merged commit a227b73 into master Mar 3, 2019

3 of 4 checks passed

codecov/project 84.61% (-0.1%) compared to fe6df2f
Details
codecov/patch Coverage not affected when comparing fe6df2f...462f725
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@juanpedromoreno juanpedromoreno deleted the jp-F-macro-fix branch Mar 3, 2019

@fedefernandez fedefernandez changed the title Macro Fix - Uses $F instead F Macro Fix - Uses the F param in macro Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.