Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus MetricsOps implementation #572

Merged
merged 13 commits into from Mar 12, 2019

Conversation

Projects
None yet
3 participants
@jdesiloniz
Copy link
Contributor

commented Mar 7, 2019

This PR adds an implementation for the MetricsOps algebra targetting Prometheus metrics.

Thanks @fedefernandez for your help with the metrics tests!

@jdesiloniz jdesiloniz self-assigned this Mar 7, 2019

@fedefernandez
Copy link
Collaborator

left a comment

Thanks @jdesiloniz. Just left a couple of comments

* {prefix}_calls_by_method{labels=classifier,method} - Histogram
* {prefix}_calls_by_method{labels=classifier,status} - Histogram
*
* `methodType` can be one of the following:

This comment has been minimized.

Copy link
@fedefernandez

fedefernandez Mar 7, 2019

Collaborator
Suggested change
* `methodType` can be one of the following:
* `method` can be one of the following:
* {prefix}_calls_header{labels=classifier} - Histogram
* {prefix}_calls_total{labels=classifier} - Histogram
* {prefix}_calls_by_method{labels=classifier,method} - Histogram
* {prefix}_calls_by_method{labels=classifier,status} - Histogram

This comment has been minimized.

Copy link
@fedefernandez

fedefernandez Mar 7, 2019

Collaborator

I think we should combine these two metrics into a single one, just adding the three labels (classifier, method, and status)

@codecov

This comment has been minimized.

Copy link

commented Mar 7, 2019

Codecov Report

Merging #572 into master will increase coverage by 0.25%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #572      +/-   ##
==========================================
+ Coverage   84.62%   84.87%   +0.25%     
==========================================
  Files          71       71              
  Lines        1099     1124      +25     
  Branches       16       16              
==========================================
+ Hits          930      954      +24     
- Misses        169      170       +1
Impacted Files Coverage Δ
...kindness/mu/rpc/dropwizard/DropWizardMetrics.scala 100% <ø> (ø) ⬆️
...rkindness/mu/rpc/internal/metrics/MetricsOps.scala 97.05% <100%> (+2.61%) ⬆️
...kindness/mu/rpc/prometheus/PrometheusMetrics.scala 92.3% <92.3%> (+92.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7f7b1b...5c1c2be. Read the comment docs.

@juanpedromoreno
Copy link
Member

left a comment

Thanks @jdesiloniz !

Javier de Siloniz Sandino added some commits Mar 12, 2019

@fedefernandez
Copy link
Collaborator

left a comment

Thanks @jdesiloniz looks good to me!

@jdesiloniz jdesiloniz merged commit 6fb3c1a into master Mar 12, 2019

4 checks passed

codecov/patch 95.23% of diff hit (target 84.62%)
Details
codecov/project 84.87% (+0.25%) compared to f7f7b1b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jdesiloniz jdesiloniz deleted the feature/jdesiloniz/513-prometheus-implementation branch Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.