Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skeuomorph integration and Proto Source Generation Support #577

Merged
merged 10 commits into from Mar 15, 2019

Conversation

Projects
None yet
6 participants
@rafaparadela
Copy link
Contributor

commented Mar 12, 2019

Closes #379

Basically, lets the idlgen plugin generate Scala code from ProtocolBuffer protocols using Skeuomorph.

@codecov

This comment has been minimized.

Copy link

commented Mar 12, 2019

Codecov Report

Merging #577 into master will increase coverage by 0.27%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #577      +/-   ##
==========================================
+ Coverage   84.87%   85.15%   +0.27%     
==========================================
  Files          71       72       +1     
  Lines        1124     1172      +48     
  Branches       16       19       +3     
==========================================
+ Hits          954      998      +44     
- Misses        170      174       +4
Impacted Files Coverage Δ
...gherkindness/mu/rpc/idlgen/SrcGenApplication.scala 0% <0%> (ø) ⬆️
...ndness/mu/rpc/idlgen/proto/ProtoSrcGenerator.scala 93.33% <93.33%> (ø)
...kindness/mu/rpc/prometheus/PrometheusMetrics.scala 88.88% <0%> (-3.42%) ⬇️
...kindness/mu/rpc/dropwizard/DropWizardMetrics.scala 100% <0%> (ø) ⬆️
.../mu/rpc/internal/interceptors/GrpcMethodInfo.scala 100% <0%> (ø) ⬆️
...rkindness/mu/rpc/internal/metrics/MetricsOps.scala 97.14% <0%> (+0.08%) ⬆️
...cala/higherkindness/mu/rpc/server/GrpcServer.scala 70.27% <0%> (+1.03%) ⬆️
...c/main/scala/higherkindness/mu/MonixAdapters.scala 92.3% <0%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fb3c1a...acfa031. Read the comment docs.

@rafaparadela rafaparadela marked this pull request as ready for review Mar 13, 2019

@rafaparadela

This comment has been minimized.

Copy link
Contributor Author

commented Mar 13, 2019

Ready for review

@juanpedromoreno
Copy link
Member

left a comment

Thanks @rafaparadela ! I left a couple of comments

@@ -0,0 +1,3 @@
> compile

This comment has been minimized.

Copy link
@juanpedromoreno

juanpedromoreno Mar 15, 2019

Member

I changed it by compile since it's being generated in that srcGen is compiled in that stage

@juanpedromoreno
Copy link
Member

left a comment

Thanks @rafaparadela . It looks great to me 🎉

@juanpedromoreno juanpedromoreno changed the title Skeuomorph integration Skeuomorph integration & Proto Source Generation Support Mar 15, 2019

@L-Lavigne
Copy link
Contributor

left a comment

Great stuff, thanks Rafa! I have a few comments, please take a look.

@fedefernandez
Copy link
Collaborator

left a comment

Looks great, left a couple of minor comments.

val copRegExp: Regex = """((Cop\[)(((\w+)(\s)?(\:\:)(\s)?)+)(TNil)(\]))""".r

val cleanCop: String => String =
_.replace("Cop[", "").replace("::", ":+:").replace("TNil]", "CNil")

This comment has been minimized.

Copy link
@pepegar

pepegar Mar 15, 2019

Member

In the future we can change this in skeuomorph directly

@pepegar
Copy link
Member

left a comment

This is awesome @rafaparadela ! thank you very much :)

LGTM

@rafaparadela rafaparadela merged commit 9ffd8ad into master Mar 15, 2019

4 checks passed

codecov/patch 87.5% of diff hit (target 84.87%)
Details
codecov/project 85.15% (+0.27%) compared to 6fb3c1a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@rafaparadela rafaparadela deleted the feature/379-proto-generation branch Mar 15, 2019

@fedefernandez fedefernandez changed the title Skeuomorph integration & Proto Source Generation Support Skeuomorph integration and Proto Source Generation Support Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.