Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapts latest changes in the code generation by Skeuomorph #579

Merged
merged 5 commits into from Mar 19, 2019

Conversation

Projects
None yet
3 participants
@rafaparadela
Copy link
Contributor

commented Mar 18, 2019

This PR closes #578

Must be in hold for now until having the Skeuomprh change released

Update project/ProjectPlugin.scala
Co-Authored-By: rafaparadela <rafa.p@47deg.com>
@codecov

This comment has been minimized.

Copy link

commented Mar 18, 2019

Codecov Report

Merging #579 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #579   +/-   ##
=======================================
  Coverage   82.27%   82.27%           
=======================================
  Files          63       63           
  Lines         965      965           
  Branches       14       14           
=======================================
  Hits          794      794           
  Misses        171      171

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ffd8ad...5309711. Read the comment docs.

@rafaparadela rafaparadela marked this pull request as ready for review Mar 18, 2019

@juanpedromoreno
Copy link
Member

left a comment

👌

juanpedromoreno and others added some commits Mar 19, 2019

Update project/ProjectPlugin.scala
Co-Authored-By: rafaparadela <rafa.p@47deg.com>

@juanpedromoreno juanpedromoreno merged commit d6a4965 into master Mar 19, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 9ffd8ad...5309711
Details
codecov/project 82.27% remains the same compared to 9ffd8ad
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@juanpedromoreno juanpedromoreno deleted the feature/578-propagate-imported-messages branch Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.