Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the compatibility of Monix.Observable in the HTTP layer #587

Merged

Conversation

Projects
None yet
3 participants
@rafaparadela
Copy link
Contributor

commented Apr 1, 2019

Just this. Close #574

@codecov

This comment has been minimized.

Copy link

commented Apr 1, 2019

Codecov Report

Merging #587 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #587   +/-   ##
=======================================
  Coverage   82.36%   82.36%           
=======================================
  Files          62       62           
  Lines         964      964           
  Branches       12       12           
=======================================
  Hits          794      794           
  Misses        170      170

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 588a83c...9c9994a. Read the comment docs.

@@ -48,25 +44,21 @@ class GreeterRestTests extends RpcBaseTestSuite with BeforeAndAfter {
val Fs2ServicePrefix = "Fs2Greeter"
val MonixServicePrefix = "MonixGreeter"

implicit val ec = monix.execution.Scheduler.Implicits.global
implicit val ec = scala.concurrent.ExecutionContext.Implicits.global

This comment has been minimized.

Copy link
@fedefernandez

fedefernandez Apr 2, 2019

Collaborator

Do you know who requires an implicit ExecutionContext? With the ContextShift it shouldn't be necessary to be implicit.

This comment has been minimized.

Copy link
@rafaparadela

rafaparadela Apr 2, 2019

Author Contributor

Merged. I’m clarifying this in my current branch. Thanks.

@fedefernandez
Copy link
Collaborator

left a comment

Left one no-blocking comment. LGTM!

@rafaparadela rafaparadela merged commit f10f14f into master Apr 2, 2019

3 checks passed

codecov/patch Coverage not affected when comparing 588a83c...9c9994a
Details
codecov/project 82.36% remains the same compared to 588a83c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rafaparadela rafaparadela deleted the feature/574-remove-Observable-compatibility-in-HTTP branch Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.