Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Allows specifying the namespace and the capitalize params #601
@@ Coverage Diff @@ ## master #601 +/- ## ========================================= + Coverage 82.36% 82.46% +0.1% ========================================= Files 62 62 Lines 964 964 Branches 12 12 ========================================= + Hits 794 795 +1 + Misses 170 169 -1
rafaparadela left a comment •
It's great to provide flexibility to define customized protocols through the
I have seen that your tests are proving that both MethodName and Namespace operate perfectly separately, but given that we are transforming the name of the service by capitalizing and concatenating the namespace, I would suggest to prove that both transformations interoperate as we expect.
Beside this minor (non-blocking) suggestion, this implementations looks great to me.
Thanks @rafaparadela. The namespace is for the service and the