Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Improves how the params are received in the annotation #602
@@ Coverage Diff @@ ## master #602 +/- ## ======================================= Coverage 82.46% 82.46% ======================================= Files 62 62 Lines 964 964 Branches 12 12 ======================================= Hits 795 795 Misses 169 169
@juanpedromoreno with these changes, the scenario in #599 is covered since it's using the scala file for generating the proto file. See https://github.com/sander/rpctest/compare/master...fedefernandez:ff/update-namespace?expand=1
I would want to create two following PRs. One with a new setting in the idl plugin for adding those annotations params and another one for the docs. Does it make sense?