Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves rpc metrics naming #607

merged 2 commits into from Apr 26, 2019


None yet
2 participants
Copy link

commented Apr 26, 2019

What this does?

Remove some unneeded prefixes from the metric labels


  • Reviewed the diff to look for typos, println and format errors.
  • Updated the docs accordingly.

fedefernandez added some commits Apr 26, 2019


This comment has been minimized.

Copy link

commented Apr 26, 2019

Codecov Report

Merging #607 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #607   +/-   ##
  Coverage   82.46%   82.46%           
  Files          62       62           
  Lines         964      964           
  Branches       12       12           
  Hits          795      795           
  Misses        169      169
Impacted Files Coverage Δ
...kindness/mu/rpc/dropwizard/DropWizardMetrics.scala 100% <ø> (ø) ⬆️
...kindness/mu/rpc/prometheus/PrometheusMetrics.scala 92.3% <ø> (ø) ⬆️
...rkindness/mu/rpc/internal/metrics/MetricsOps.scala 97.05% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 635abd0...af6d25f. Read the comment docs.

@fedefernandez fedefernandez merged commit 7de48d3 into master Apr 26, 2019

4 checks passed

codecov/patch 100% of diff hit (target 82.46%)
codecov/project 82.46% (+0%) compared to 635abd0
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@fedefernandez fedefernandez deleted the ff/rpc-statuses-metrics branch Apr 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.