Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes metric prefix #609

merged 2 commits into from May 7, 2019


None yet
3 participants
Copy link

commented May 7, 2019

What this does?

Fixes an issue with the metrics name. It also releases a new patch version


  • Reviewed the diff to look for typos, println and format errors.
  • Updated the docs accordingly.

fedefernandez added some commits May 7, 2019


This comment has been minimized.

Copy link

commented May 7, 2019

Codecov Report

Merging #609 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #609   +/-   ##
  Coverage   82.46%   82.46%           
  Files          62       62           
  Lines         964      964           
  Branches       12       12           
  Hits          795      795           
  Misses        169      169
Impacted Files Coverage Δ
...kindness/mu/rpc/prometheus/PrometheusMetrics.scala 92.3% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7de48d3...d1f3136. Read the comment docs.

@fedefernandez fedefernandez merged commit 8a112fa into master May 7, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 7de48d3...d1f3136
codecov/project 82.46% remains the same compared to 7de48d3
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@fedefernandez fedefernandez deleted the ff/fix-metrics-bug branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.