Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use updated Skeuomorph version for non-primitive protobuf fields #614

Merged
merged 1 commit into from May 28, 2019

Conversation

Projects
None yet
3 participants
@noelmarkham
Copy link
Contributor

commented May 28, 2019

What this does?

  • Fixes #612, having optional fields for non-primitive protobuf fields.
  • Added fs2 prefix to the Stream type of a test, which was also included in this release

Checklist

  • Reviewed the diff to look for typos, println and format errors.
  • Updated the docs accordingly.
Use updated Skeuomorph version for non-primitive protobuf fields
 - And added `fs2` prefix to the Stream type, which was also included in this release

@noelmarkham noelmarkham requested review from rafaparadela and L-Lavigne May 28, 2019

@juanpedromoreno

This comment has been minimized.

Copy link
Member

commented May 28, 2019

Thanks @noelmarkham !

@codecov

This comment has been minimized.

Copy link

commented May 28, 2019

Codecov Report

Merging #614 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #614      +/-   ##
==========================================
- Coverage   82.46%   82.36%   -0.11%     
==========================================
  Files          62       62              
  Lines         964      964              
  Branches       12       12              
==========================================
- Hits          795      794       -1     
- Misses        169      170       +1
Impacted Files Coverage Δ
...ndness/mu/rpc/idlgen/proto/ProtoSrcGenerator.scala 86.66% <0%> (-6.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e90cf8...f09a479. Read the comment docs.

@noelmarkham noelmarkham merged commit 3289e3c into master May 28, 2019

3 of 4 checks passed

codecov/project 82.36% (-0.11%) compared to 8f8cd95
Details
codecov/patch Coverage not affected when comparing 8f8cd95...f09a479
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@noelmarkham noelmarkham deleted the feature/612-optional-proto-fields branch May 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.