Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Bazel 25 compatibility #185

Merged
merged 3 commits into from May 17, 2019

Conversation

Projects
None yet
2 participants
@jjudd
Copy link
Collaborator

commented May 8, 2019

Includes a few extra commits. Currently a work in progress.

Update protobuf to remove warning
The older version of protobuf is causing a warning like:
An illegal reflective access operation has occurred

@jjudd jjudd force-pushed the lucidsoftware:bazel25 branch 3 times, most recently from 4415cf1 to 905f377 May 8, 2019

@andyscott

This comment has been minimized.

Copy link
Member

commented May 9, 2019

When do you think this one will be ready?

@jjudd

This comment has been minimized.

Copy link
Collaborator Author

commented May 9, 2019

Early next week if that works.

@jjudd jjudd force-pushed the lucidsoftware:bazel25 branch 7 times, most recently from 55dc9aa to c3e8963 May 16, 2019

@andyscott

This comment has been minimized.

Copy link
Member

commented May 16, 2019

🤞

jjudd added some commits May 7, 2019

Bazel 25 compatibility
Includes updating the _java attribute to use current_java_runtime and get rid
of warnings.

The current code with more recent versions of Bazel causes a warning about
using the deprecated target '@local_jdk//:java' and to use use
@bazel_tools//tools/jdk:current_java_runtime instead (see
bazelbuild/bazel#5594).

Resolves #122

@jjudd jjudd force-pushed the lucidsoftware:bazel25 branch from 33fc36b to 5c1d0a9 May 17, 2019

@jjudd

This comment has been minimized.

Copy link
Collaborator Author

commented May 17, 2019

CI is good. Commits are squashed into something more reasonable. This is ready for review.

@andyscott
Copy link
Member

left a comment

Awesome. LGTM!

@andyscott andyscott merged commit 81dd793 into higherkindness:master May 17, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.