Code Review for Job #18716 #156

Merged
merged 5 commits into from Nov 27, 2012

1 participant

@birarda
High Fidelity member

Code Review for Job #18716 - Workitem available at https://www.worklist.net/worklist/workitem.php?job_id=18716&action=view

@stojce stojce and 1 other commented on an outdated diff Nov 20, 2012
candpiosapp/Settings/SettingsMenuController.m
if (!touchView) {
- // place an invisible view over the VC's view to handle touch
- CGRect touchFrame = CGRectMake(0, 0, visibleVC.view.frame.size.width, visibleVC.view.frame.size.height);
+ // height of the touch view is the device height, minus navigation bar
+ CGFloat navBarHeight = visibleNC.navigationBar.frame.size.height;
+ CGFloat touchViewHeight = self.cpTabBarController.view.frame.size.height - navBarHeight;
+
+ CGRect touchFrame = CGRectMake(0,
+ 0 + navBarHeight,
@stojce
High Fidelity member
stojce added a note Nov 20, 2012

Is this 0 + necessary?

@birarda
High Fidelity member
birarda added a note Nov 27, 2012

nope, I'm an idiot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@birarda birarda merged commit 58a9b65 into highfidelity:master Nov 27, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment