Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Adds ability to void transactions & removes refunds decline_all_cards context #30

Merged
merged 3 commits into from Nov 5, 2012

Conversation

Projects
None yet
2 participants
Contributor

robertjwhitney commented Oct 3, 2012

Adds ability to void transactions, and removes branch for decline_all_cards on refunds. Neither of these methods should ever return a card declined error. Also, adds methods to Readme.

Robert Whitney added some commits Oct 3, 2012

@gabebw gabebw commented on the diff Nov 2, 2012

lib/fake_braintree/sinatra_app.rb
@@ -130,17 +130,20 @@ def hash_from_request_body_with_key(request, key)
end
# Braintree::Transaction.refund
- # Braintree::CreditCard.refund
@gabebw

gabebw Nov 2, 2012

Contributor

Why did you remove this? Both methods POST to this URL, unless I'm missing something.

@robertjwhitney

robertjwhitney Nov 4, 2012

Contributor

I don't believe Braintree:::CreditCard has this method, does it?

https://github.com/braintree/braintree_ruby/blob/master/lib/braintree/credit_card.rb

@gabebw gabebw pushed a commit that referenced this pull request Nov 5, 2012

Gabe Berke-Williams Merge pull request #30 from robertjwhitney/voids_refunds
Adds ability to void transactions & removes refunds decline_all_cards context
7590d60

@gabebw gabebw merged commit 7590d60 into highfidelity:master Nov 5, 2012

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment