New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Avatar > Attachments joint and spinboxes #13351

Merged
merged 3 commits into from Jun 14, 2018

Conversation

Projects
None yet
6 participants
@ctrlaltdavid
Collaborator

ctrlaltdavid commented Jun 12, 2018

  • Fix setting attachment joint in Avatar > Attachments dialog.
  • Fix QML spinbox min/max values.
  • Fix QML spinbox not validating second time you enter invalid value.
@ctrlaltdavid

This comment has been minimized.

Show comment
Hide comment
@ctrlaltdavid

ctrlaltdavid Jun 12, 2018

Collaborator

Test Plan

Vive required.

Using default avatar, desktop mode, 3rd person view so that you can see your avatar.

  1. Test the Avatar > Attachments dialog...

    1. Test setting the attachment joint.

      • Attach the following model to your avatar's "Head" joint: https://s3-us-west-1.amazonaws.com/hifidomain/New+folder/emohair.fbx. It should appear embedded in your avatar's head.
      • Change the joint to "HeadTop_End" joint. The attachment should move up to near the top of your avatar's head.
      • Try a few more joints.
      • Restart Interface. The attachment should appear on the same joint and position as before.
    2. Test min/max translation values. Values should be able to range between -10 and 10. (Previously, they could only range from 0 to 10.)

    3. Test min/max rotation values. Values should be able to range between -180 and 180. (Previously, the could only range from 0 to 180.)

    4. Test that the second time you type in an out of range value to a spinbox - e.g., enter 200 twice - the value is changed to the closest in-range value - e.g., 180 - both times. (Previously, the second time you entered the invalid value it would be changed.)

    5. Check values are remembered over Interface restarts. NOTE: Test values not equal to -180 or 180. Rotation values are converted to a quaternion for usage, then converted from a quaternion to the 3 rotation values for display, so values displayed may have changed among equivalents (e.g., 0,180,180 -> 180,0,0) but the in-world orientation of the attachment should remain the same.

  2. Check the spin box operations in other QML dialogs:

    • Settings > General
    • Settings > Control - Including OpenVR configuration dialog.
    • Settings > Avatar

https://highfidelity.manuscript.com/f/cases/14938

Collaborator

ctrlaltdavid commented Jun 12, 2018

Test Plan

Vive required.

Using default avatar, desktop mode, 3rd person view so that you can see your avatar.

  1. Test the Avatar > Attachments dialog...

    1. Test setting the attachment joint.

      • Attach the following model to your avatar's "Head" joint: https://s3-us-west-1.amazonaws.com/hifidomain/New+folder/emohair.fbx. It should appear embedded in your avatar's head.
      • Change the joint to "HeadTop_End" joint. The attachment should move up to near the top of your avatar's head.
      • Try a few more joints.
      • Restart Interface. The attachment should appear on the same joint and position as before.
    2. Test min/max translation values. Values should be able to range between -10 and 10. (Previously, they could only range from 0 to 10.)

    3. Test min/max rotation values. Values should be able to range between -180 and 180. (Previously, the could only range from 0 to 180.)

    4. Test that the second time you type in an out of range value to a spinbox - e.g., enter 200 twice - the value is changed to the closest in-range value - e.g., 180 - both times. (Previously, the second time you entered the invalid value it would be changed.)

    5. Check values are remembered over Interface restarts. NOTE: Test values not equal to -180 or 180. Rotation values are converted to a quaternion for usage, then converted from a quaternion to the 3 rotation values for display, so values displayed may have changed among equivalents (e.g., 0,180,180 -> 180,0,0) but the in-world orientation of the attachment should remain the same.

  2. Check the spin box operations in other QML dialogs:

    • Settings > General
    • Settings > Control - Including OpenVR configuration dialog.
    • Settings > Avatar

https://highfidelity.manuscript.com/f/cases/14938

@hifi-gustavo

This comment has been minimized.

Show comment
Hide comment

@ctrlaltdavid ctrlaltdavid added this to the RC69 milestone Jun 12, 2018

@hifi-gustavo

This comment has been minimized.

Show comment
Hide comment
@hifi-gustavo

This comment has been minimized.

Show comment
Hide comment
@hifi-gustavo

This comment has been minimized.

Show comment
Hide comment
@hifi-gustavo

This comment has been minimized.

Show comment
Hide comment
@qlikmorales

This comment has been minimized.

Show comment
Hide comment
@qlikmorales

qlikmorales Jun 12, 2018

Currently Testing

qlikmorales commented Jun 12, 2018

Currently Testing

@qlihifitest

This comment has been minimized.

Show comment
Hide comment
@qlihifitest

qlihifitest Jun 12, 2018

@conklin94122
Fail

Test plan fails: When restarting the interface the values in the spinbox (Avatar > Attachment: Rotation) don't save.

Step 1 > v.

hifi-log.txt
Spinbox.zip

"Still qlikmorales, used wrong profile."

qlihifitest commented Jun 12, 2018

@conklin94122
Fail

Test plan fails: When restarting the interface the values in the spinbox (Avatar > Attachment: Rotation) don't save.

Step 1 > v.

hifi-log.txt
Spinbox.zip

"Still qlikmorales, used wrong profile."

@ctrlaltdavid

This comment has been minimized.

Show comment
Hide comment
@ctrlaltdavid

ctrlaltdavid Jun 13, 2018

Collaborator

@qlihifitest Rotation values are converted to a quaternion when the dialog is closed, then converted back to 3 values for display when the dialog is re-opened, so values may appear to have changed when the dialog is reopened after an Interface restart but the attachment should be in the same position as before. For example, 180,180,180 redisplays as 0,0,0. And in the Spinbox.zip video 0, 180,-180 is redisplayed as 180,0,0. If the attachment was visible you'd see that it still had the same in-world orientation.

If added a note to set 1 > v to test values other than +/-180 and check the visible orientation of the attachment.

Collaborator

ctrlaltdavid commented Jun 13, 2018

@qlihifitest Rotation values are converted to a quaternion when the dialog is closed, then converted back to 3 values for display when the dialog is re-opened, so values may appear to have changed when the dialog is reopened after an Interface restart but the attachment should be in the same position as before. For example, 180,180,180 redisplays as 0,0,0. And in the Spinbox.zip video 0, 180,-180 is redisplayed as 180,0,0. If the attachment was visible you'd see that it still had the same in-world orientation.

If added a note to set 1 > v to test values other than +/-180 and check the visible orientation of the attachment.

@qlihifitest

This comment has been minimized.

Show comment
Hide comment
@qlihifitest

qlihifitest Jun 14, 2018

Currently Testing

qlihifitest commented Jun 14, 2018

Currently Testing

@qlihifitest

This comment has been minimized.

Show comment
Hide comment
@qlihifitest

qlihifitest commented Jun 14, 2018

@hyperlogic hyperlogic merged commit f2d6d0e into highfidelity:master Jun 14, 2018

2 checks passed

default Build finished.
Details
license/cla Contributor License Agreement is signed.
Details

@ctrlaltdavid ctrlaltdavid deleted the ctrlaltdavid:21891 branch Jun 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment