New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC73.2: avoid backwards seek for skipped trait deletes #14152

Merged
merged 1 commit into from Oct 6, 2018

Conversation

@birarda
Member

birarda commented Oct 5, 2018

No description provided.

@birarda birarda added this to the v0.73.2 milestone Oct 5, 2018

@ZappoMan

Project approved!

@conklin94122

pre-emptive qa approval so we can merge, save time. still needs to be tested.

@hifi-gustavo

This comment has been minimized.

Show comment
Hide comment
@hifi-gustavo

This comment has been minimized.

Show comment
Hide comment
@hifi-gustavo

This comment has been minimized.

Show comment
Hide comment
@hifi-gustavo

This comment has been minimized.

Show comment
Hide comment
@hifi-gustavo

This comment has been minimized.

Show comment
Hide comment
@antoninahifi

This comment has been minimized.

Show comment
Hide comment
@antoninahifi

antoninahifi Oct 5, 2018

currently testing

antoninahifi commented Oct 5, 2018

currently testing

@birarda

This comment has been minimized.

Show comment
Hide comment
@birarda

birarda Oct 5, 2018

Member

Test Plan

  1. Enable clumsy. Add 5% out of order and dropped packets on all receiving traffic.
  2. From 73.1, connect to distributed2. Switch to a different domain and reconnect to distributed2. Repeat that process until you crash.
  3. With clumsy still on, repeat those steps with this PR. You should not crash.
Member

birarda commented Oct 5, 2018

Test Plan

  1. Enable clumsy. Add 5% out of order and dropped packets on all receiving traffic.
  2. From 73.1, connect to distributed2. Switch to a different domain and reconnect to distributed2. Repeat that process until you crash.
  3. With clumsy still on, repeat those steps with this PR. You should not crash.
@JeffClinton

PASS @conklin94122

Orange cube disappears properly on mac and windows. Android smoke was a pass.

@JeffClinton

Approved by accident

@antoninahifi

This comment has been minimized.

Show comment
Hide comment
@antoninahifi

antoninahifi Oct 6, 2018

@conklin94122 PASS
verified that “in a domain, wear and delete some avatar entities and make sure another user sees you delete them”

antoninahifi commented Oct 6, 2018

@conklin94122 PASS
verified that “in a domain, wear and delete some avatar entities and make sure another user sees you delete them”

approved by mistake

@conklin94122

This comment has been minimized.

Show comment
Hide comment
@conklin94122

conklin94122 Oct 6, 2018

Contributor

I double checked and @antoninahifi confirms that this is indeed ready to be merged.

Contributor

conklin94122 commented Oct 6, 2018

I double checked and @antoninahifi confirms that this is indeed ready to be merged.

@conklin94122 conklin94122 merged commit 835c437 into highfidelity:v0.73.2-rc Oct 6, 2018

2 checks passed

default Build finished.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment