Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Linux Build Guide's Cmake issue #15029

Merged
merged 3 commits into from Mar 12, 2019

Conversation

@FlameSoulis
Copy link
Contributor

commented Feb 26, 2019

This adds a fix for issue #14171 by just using the cmake provided from cmake.org (their official website). It also updates the checkout to the current latest (Build Release 79).

This does not resolve the python issue, though that should also be addressed as python 3.6 is not available on Ubuntu 16.04. However, builds have been working fine for the server using 2.7, which is available.

FlameSoulis added some commits Feb 26, 2019

Merge pull request #3 from highfidelity/master
Master Update PR 20190226
@hifi-gustavo

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2019

Can someone from High Fidelity approve this PR?

@shanzzam shanzzam added this to the v0.81.0 milestone Mar 9, 2019

@shanzzam shanzzam requested review from NissimHadar and Atlante45 Mar 9, 2019

@@ -37,8 +37,14 @@ sudo apt-get -y install libpulse0 libnss3 libnspr4 libfontconfig1 libxcursor1 li

Install build tools:
```bash
# For Ubuntu 18.04

This comment has been minimized.

Copy link
@NissimHadar

NissimHadar Mar 9, 2019

Contributor

Will this work also for 18.10?

This comment has been minimized.

Copy link
@FlameSoulis

FlameSoulis Mar 10, 2019

Author Contributor

I haven't tested it under 18.10. This PR was strictly for dealing with 16.04 fixes and the guide focuses on 16.04 and 18.04 due to being LTS. I guess it would.

@@ -61,7 +67,7 @@ git tags

Then checkout last tag with:
```bash
git checkout tags/v0.71.0
git checkout tags/v0.79.0

This comment has been minimized.

Copy link
@NissimHadar

NissimHadar Mar 9, 2019

Contributor

We will soon be on 0.80.0 - wouldn't it be better if there was some time of run-time argument we could pass in?

This comment has been minimized.

Copy link
@FlameSoulis

FlameSoulis Mar 10, 2019

Author Contributor

Yeah, I can go ahead with it, though 79.1 is due soon and this appears to been put under milestone 81, so I guess it is their call which version should be reflected for when it gets applied to the master.

This comment has been minimized.

Copy link
@Atlante45

Atlante45 Mar 11, 2019

Contributor

Let's add a message like this:

You can find out what the latest tag is with git describe --tags
Or at https://github.com/highfidelity/hifi/releases

@shanzzam

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

build this please

@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

Android build is available here. Quest build is available here

@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

@highfidelity highfidelity deleted a comment from hifi-gustavo Mar 12, 2019

@highfidelity highfidelity deleted a comment from shanzzam Mar 12, 2019

@highfidelity highfidelity deleted a comment from hifi-gustavo Mar 12, 2019

@highfidelity highfidelity deleted a comment from hifi-gustavo Mar 12, 2019

@highfidelity highfidelity deleted a comment from hifi-gustavo Mar 12, 2019

@highfidelity highfidelity deleted a comment from hifi-gustavo Mar 12, 2019

@highfidelity highfidelity deleted a comment from shanzzam Mar 12, 2019

@shanzzam shanzzam merged commit 88da09c into highfidelity:master Mar 12, 2019

2 checks passed

default Build finished.
Details
license/cla Contributor License Agreement is signed.
Details

@FlameSoulis FlameSoulis deleted the FlameSoulis:fix/Linux-Build-Guide branch Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.