Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

case 21980: Allow copying grandchild entities #15281

Merged
merged 1 commit into from Apr 8, 2019

Conversation

@orenh1
Copy link
Contributor

commented Mar 28, 2019

In Create mode, users can select entities, and then use Copy and Paste to duplicate them. This is supposed to be recursive, i.e. when an entity is copied all of its descendants are copied as well. However, there was a bug: only an entity's direct children were copied, but not their children. This pull request fixes that. (Also, it makes the logging consistent wherever the error "conflicting entityHostType" occurs.)

https://highfidelity.fogbugz.com/f/cases/21980/in-CREATE-app-copy-and-paste-doesn-t-copy-grandchildren

Using Copy/Paste on entities only worked for one level of children, but not for grandchildren.
@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

Android build is available here. Quest build is available here

@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

@sethalves sethalves added this to the v0.83.0 milestone Mar 28, 2019
@thoys
thoys approved these changes Mar 28, 2019
}
continue;
}

if (!(id in entities)) {
entities[id] = Entities.getEntityProperties(id);
appendChildren(id, entities);
appendChildren(id, entities, entityHostType);

This comment has been minimized.

Copy link
@thoys

thoys Mar 28, 2019

Contributor

good find

@sethalves sethalves changed the title Allow copying grandchild entities case 21980: Allow copying grandchild entities Mar 29, 2019
Copy link
Contributor

left a comment

83.0 PA

@thoys thoys merged commit 98e0164 into highfidelity:master Apr 8, 2019
2 checks passed
2 checks passed
default Build finished.
Details
license/cla Contributor License Agreement is signed.
Details
@orenh1 orenh1 deleted the kitely:copy-grandchild-entities branch Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.