Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

case 22190: Disable triggering away state when interface focus lost #15301

Merged

Conversation

@SaracenOne
Copy link
Contributor

commented Mar 31, 2019

This PR adds important functionality which I initially had in my PR before an alternative fix was merged instead for retaining hand-tracking in the Oculus Dash menu: a setting to prevent being forced into an away state when mouse focus was lost on the interface window. This is necessary because the main point of the Oculus Dash fix was to allow people to visibly operate other external software such as Discord for messaging while allowing their hands to be shown visibly typing, which was based on user preference from users who use this functionality a lot in other similar social VR software.

This version also adds an option to toggle this from the general settings menu under the setting 'Go into away state when interface window loses focus in VR'. The setting is on by default, will retain current behavior unless otherwise turned off, and setting persists across sessions. When turned off, it will be possible when bringing up the new Oculus Dash to navigate to other windows via the virtual desktop without being forced into an away state.

https://highfidelity.fogbugz.com/f/cases/22190/Disable-triggering-away-state-when-interface-focus-lost

@hifi-gustavo

This comment has been minimized.

Copy link
Contributor

commented Mar 31, 2019

Can someone from High Fidelity approve this PR?

1 similar comment
@hifi-gustavo

This comment has been minimized.

Copy link
Contributor

commented Mar 31, 2019

Can someone from High Fidelity approve this PR?

@SamGondelman

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

add to whitelist

@hifi-gustavo

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

Android build is available here. Quest build is available here

@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

@sethalves sethalves changed the title Disable triggering away state when interface focus lost case 22190: Disable triggering away state when interface focus lost Apr 12, 2019

@SamGondelman SamGondelman added this to the v0.84.0 milestone Apr 16, 2019

@SamGondelman SamGondelman added the Engine label Apr 16, 2019

scripts/system/away.js Outdated Show resolved Hide resolved
@SaracenOne

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

Should be dealt with now.

@hifi-gustavo

This comment has been minimized.

Copy link
Contributor

commented May 9, 2019

Android build is available here. Quest build is available here

@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

@qaAdamSmith82

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

Pre-Merge tests pass

@shanzzam shanzzam merged commit 32d3014 into highfidelity:master May 13, 2019

2 checks passed

default Build finished.
Details
license/cla Contributor License Agreement is signed.
Details

@shanzzam shanzzam modified the milestones: v0.84.0, v0.83.0 May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.