Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

case 22189: Add display name field to the log in screen. #15334

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@SaracenOne
Copy link
Contributor

commented Apr 5, 2019

This simply adds a new field which allows new users logging in to set their display name since new users will not likely be aware that their display name defaults to anonymous and how to change it. By default, it will fill this field with whatever your local display name currently is. Your display name will be changed to whatever is written in this field only when you log in.

https://highfidelity.fogbugz.com/f/cases/22189/Add-display-name-field-to-the-log-in-screen

@hifi-gustavo

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2019

Can someone from High Fidelity approve this PR?

1 similar comment
@hifi-gustavo

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2019

Can someone from High Fidelity approve this PR?

@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

Android build is available here. Quest build is available here

@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

@sethalves sethalves added this to the v0.84.0 milestone Apr 12, 2019

@sethalves sethalves changed the title Add display name field to the log in screen. case 22189: Add display name field to the log in screen. Apr 12, 2019

@wayne-chen
Copy link
Contributor

left a comment

typos with displayName needing to be displayNameField.

@SaracenOne SaracenOne force-pushed the SaracenOne:screen_name_at_signup_push branch from 67dc2de to 36af2c8 Apr 16, 2019

@SaracenOne

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

The change @wayne-chen requested has now been pushed. Apologies for the oversight.

@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

Android build is available here. Quest build is available here

@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.