Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible fix for shader compilation error #15927

Merged
merged 1 commit into from Jul 15, 2019

Conversation

@SamGondelman
Copy link
Contributor

commented Jul 12, 2019

This might fix AO? (edit: this does not fix AO)

Seth was seeing:

[07/12 16:04:42] [DEBUG] [hifi.gl] GLShader::compileProgram -  failed to LINK the gl program object :
[07/12 16:04:42] [DEBUG] [hifi.gl] error: vertex shader output `varTexCoord0' declared as type `vec2', but fragment shader input declared as type `vec4'

varTexCoord0 is a vec4 in two places: ssao_bilateralBlur.slf and ssao_gather.slf. ssao_bilateralBlur.slv outputs a vec4, but ssao_gather.slp uses gpu::vertex::DrawViewportQuadTransformTexcoord which outputs a vec2. varTexCoord0 isn't even used in ssao_gather.slf so we can just remove it.

@hifi-gustavo

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

Android build is available here. Quest build is available here

@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

@shanzzam shanzzam added this to the v0.83.0 milestone Jul 15, 2019

@AndrewMeadows

This comment has been minimized.

Copy link
Contributor

commented Jul 15, 2019

I can confirm: varTexCoord0 is not used by ssao_gather.slf and can be removed.

@shanzzam
Copy link
Contributor

left a comment

PA

@shanzzam shanzzam merged commit d37456e into highfidelity:master Jul 15, 2019

2 checks passed

default Build finished.
Details
license/cla Contributor License Agreement is signed.
Details

@SamGondelman SamGondelman deleted the SamGondelman:error branch Jul 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.