Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condense directional light shaders using slp defines #15939

Merged
merged 1 commit into from Jul 24, 2019

Conversation

@SamGondelman
Copy link
Contributor

commented Jul 16, 2019

These shaders were all nearly identical.

Test plan:

  • With deferred rendering, the following should all appear the same as in master:
    • lighting in a zone with a skybox but no ambient map, without shadows
    • lighting in a zone with a skybox but no ambient map, with shadows
    • lighting in a zone with a skybox and an ambient map, without shadows
    • lighting in a zone with a skybox and an ambient map, with shadows
@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

Android build is available here. Quest build is available here

@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

@shanzzam shanzzam added this to the v0.83.0 milestone Jul 24, 2019

@shanzzam shanzzam merged commit 2942bfa into highfidelity:master Jul 24, 2019

2 checks passed

default Build finished.
Details
license/cla Contributor License Agreement is signed.
Details

@SamGondelman SamGondelman deleted the SamGondelman:shader branch Jul 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.