Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGZ-1022: Restore avatar theft functionality to Lilypad #15954

Merged
merged 2 commits into from Jul 22, 2019

Conversation

@SimonWalton-HiFi
Copy link
Contributor

commented Jul 19, 2019

https://highfidelity.atlassian.net/browse/BUGZ-1022

Mostly combines #15930 & #15574.
Regarding Tony's comment #15574 (review): I attempted using Array.prototype.find (or findIndex) but they do not appear to be supported by Qt's JS as they are recent language additions. Instead I've used Array.prototype.every, which is a little cleaner than just a loop.

@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2019

Android build is available here. Quest build is available here

@howard-stearns
Copy link
Contributor

left a comment

as stated

@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2019

Android build is available here. Quest build is available here

@hifi-gustavo

This comment has been minimized.

@hifi-gustavo

This comment has been minimized.

@shanzzam
Copy link
Contributor

left a comment

PA

@shanzzam shanzzam merged commit a0d0963 into highfidelity:master Jul 22, 2019

2 checks passed

default Build finished.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.