Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Solidity highlighting #2047

Closed
abcoathup opened this issue May 31, 2019 · 5 comments
Closed

Add Solidity highlighting #2047

abcoathup opened this issue May 31, 2019 · 5 comments

Comments

@abcoathup
Copy link

@abcoathup abcoathup commented May 31, 2019

I will work on a PR

@abcoathup

This comment has been minimized.

Copy link
Author

@abcoathup abcoathup commented Jun 7, 2019

@marcoscaceres I want to get Solidity highlighting working in a hosted Discourse forum
https://meta.discourse.org/t/how-to-get-solidity-syntax-highlighting/117774

The Discourse recommendation was to get Solidity added as a language to highlightjs. With the move to having new languages in their own repo, how can highlightjs be configured to use the https://github.com/highlightjs/highlightjs-solidity repo? Is there existing documentation?

As an aside, may need to add some documentation that new languages should be created in separate repos.

Note: PR is now closed. #2051

@marcoscaceres

This comment has been minimized.

Copy link
Collaborator

@marcoscaceres marcoscaceres commented Jun 7, 2019

You should be able to put together a custom bundle - see example:

https://github.com/w3c/respec-hljs

@yyyc514

This comment has been minimized.

Copy link
Member

@yyyc514 yyyc514 commented Oct 7, 2019

@abcoathup I'd like to make this much, much easier where you can just download the repos and then run the build command but just started digging into the idea.

@abcoathup

This comment has been minimized.

Copy link
Author

@abcoathup abcoathup commented Oct 7, 2019

Hi @yyyc514,

Sounds great.

Discourse built a theme component so we could get Solidity highlights:
https://forum.openzeppelin.com/t/discourse-solidity-syntax-highlighting/267/11

@yyyc514

This comment has been minimized.

Copy link
Member

@yyyc514 yyyc514 commented Dec 26, 2019

Closing this issue since we have the https://github.com/highlightjs/highlightjs-solidity repository in place now.

@yyyc514 yyyc514 closed this Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.