Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(yaml) Tags should allow non-word characters #2486

Closed
pplantinga opened this issue Apr 9, 2020 · 2 comments
Closed

(yaml) Tags should allow non-word characters #2486

pplantinga opened this issue Apr 9, 2020 · 2 comments

Comments

@pplantinga
Copy link
Contributor

@pplantinga pplantinga commented Apr 9, 2020

Describe the issue
YAML tags can include some non-word characters (e.g. period, dollar sign) but current highlighting only matches letters and underscores

Which language seems to have the issue?
YAML

Sample Code to Reproduce
https://jsfiddle.net/7ukmfhsv/

Expected behavior
yaml-highlight

@joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Apr 9, 2020

Confirmed. Should be a simple fix. PR welcome.

pplantinga added a commit to pplantinga/highlight.js that referenced this issue Apr 9, 2020
pplantinga added a commit to pplantinga/highlight.js that referenced this issue Apr 9, 2020
@joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Apr 17, 2020

@pplantinga Any chance you'd be interested in #2475? It's gotta be much simpler than this. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants