Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redefine src/test.html into src/demo.html #542

Closed
isagalaev opened this issue Aug 15, 2014 · 7 comments

Comments

Projects
None yet
3 participants
@isagalaev
Copy link
Member

commented Aug 15, 2014

Since we now have real tests, src/test.html should become a demo page. It's worth at least renaming it and probably also start stripping big snippets off of code repetitions used to test edge cases.

@isagalaev isagalaev added this to the 8.2 milestone Aug 15, 2014

@isagalaev isagalaev self-assigned this Aug 15, 2014

@isagalaev isagalaev removed this from the 8.2 milestone Aug 20, 2014

@isagalaev

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2014

Denominating from 8.2. I decided to make a more involved redesign and there's no rush. Current plan includes:

  • redesigning the page visually, refactoring old js code
  • generating snippets from tests to remove code duplication
  • updating docs

@Sannis Sannis added the feature label Aug 30, 2014

@ghost

This comment has been minimized.

Copy link

commented Sep 25, 2014

In the demo page, I think you could keep the theme selection menu visible as the page is scrolled down.

@ghost

This comment has been minimized.

Copy link

commented Sep 25, 2014

Also, you could have a demo where the user types his OWN code, and sees for himself how cool this syntax highlighting is, and why he should switch from prism.js to yours!

@isagalaev

This comment has been minimized.

Copy link
Member Author

commented Sep 25, 2014

Uhm… Thank you but I don't have a shortage of nice (and obvious) ideas, really. I'd much rather see someone to volunteer to implement all of it.

@ghost

This comment has been minimized.

Copy link

commented Sep 25, 2014

Well I could, but i'm too busy doing other stuff.

@simsalabim

This comment has been minimized.

Copy link

commented Sep 26, 2014

how you think OSS apps are maintained

@isagalaev

This comment has been minimized.

Copy link
Member Author

commented Nov 8, 2014

Landed.

@isagalaev isagalaev closed this Nov 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.