Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(php) highlight variables #2785

Merged

Conversation

taufik-nurrohman
Copy link
Contributor

@taufik-nurrohman taufik-nurrohman commented Oct 25, 2020

Resolve #2778

Checklist

  • Tested.
  • Updated the changelog at CHANGES.md

src/languages/php.js Outdated Show resolved Hide resolved
@joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Oct 25, 2020

You'll also need to update the tests in markup/php to match your grammar change.

Copy link
Member

@joshgoebel joshgoebel left a comment

Please update according to notes. Thanks!

@joshgoebel joshgoebel changed the title Highlight PHP Variable enh(php) highlight variables Oct 25, 2020
@joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Oct 27, 2020

Please finish checklist! Looking good!

@joshgoebel joshgoebel added the hacktoberfest-accepted label Oct 27, 2020
@joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Oct 27, 2020

@taufik-nurrohman Thanks so much!

@joshgoebel joshgoebel merged commit 95ad819 into highlightjs:master Oct 27, 2020
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants