Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chapel as a supported third-party language #2806

Merged
merged 3 commits into from Nov 2, 2020

Conversation

bradcray
Copy link
Contributor

@bradcray bradcray commented Oct 30, 2020

Resolves #2800

Changes

This adds an entry for the Chapel language, giving chapel and chpl as its two aliases, and pointing to our repo at https://github.com/chapel-lang/highlightjs-chapel.

Checklist

  • Added markup tests, or they don't apply here because they're in our repo
  • Updated the changelog at CHANGES.md
  • Added myself to AUTHORS.txt, under Contributors (wasn't certain whether adding a third-party package warranted being added to AUTHORS.txt and @joshgoebel didn't seem certain either)

[Note: I haven't done the last two items because it's not clear to me whether they apply to something as minor as adding a new third-party language to the list. Please let me know]

---
Signed-off-by: Brad Chamberlain <bradcray@users.noreply.github.com>
@joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Oct 31, 2020

I dunno about authors (I won't stop ya, but I've never really thought about it), but you can definitely add an entry to the changelog if you'd like!

@joshgoebel joshgoebel added this to the 10.4 milestone Oct 31, 2020
---
Signed-off-by: Brad Chamberlain <bradcray@users.noreply.github.com>
@bradcray
Copy link
Contributor Author

@bradcray bradcray commented Nov 2, 2020

@joshgoebel: I added a CHANGES.md entry as suggested. I skipped the AUTHORS.md update, but can do it if you prefer. Let me know if there are any other changes required before this is merged (Travis testing is still pending as I write this).

[Also, in other news, I successfully got our Discourse site using Chapel highlighting even without this being merged which I consider a major win]

CHANGES.md Outdated Show resolved Hide resolved
@joshgoebel joshgoebel merged commit 66a2598 into highlightjs:master Nov 2, 2020
1 check was pending
@bradcray bradcray deleted the add-chapel-as-3rd-party branch Nov 2, 2020
@bradcray
Copy link
Contributor Author

@bradcray bradcray commented Nov 2, 2020

Thanks Josh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants