Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected typo in Vue plugin setting detectedLanguage #2807

Merged
merged 4 commits into from Nov 2, 2020

Conversation

rushimusmaximus
Copy link
Contributor

@rushimusmaximus rushimusmaximus commented Oct 30, 2020

Fixed typo this.detectectLanguage -> this.detectedLanguage when rendering content when a language has been provided. In that case detectedLanguage was not getting set, which meant the computed className was also not getting the language.

Changes

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md
  • Added myself to AUTHORS.txt, under Contributors

Fixed typo `this.detectectLanguage` -> `this.detectedLanguage` when rendering content when a language has been provided. In that case detectedLanguage was not getting set, which meant the computed className was also not getting the language.
@joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Oct 31, 2020

It's a bug fix, please continue with the checklist. :-) At least a changelog entry.

@joshgoebel joshgoebel added the hacktoberfest-accepted label Oct 31, 2020
@joshgoebel joshgoebel added this to the 10.4 milestone Oct 31, 2020
@joshgoebel joshgoebel merged commit 3971170 into highlightjs:master Nov 2, 2020
1 check was pending
@joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Nov 2, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants