Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(parser) use negative look-ahead for beginKeywords #2813

merged 5 commits into from Nov 13, 2020


Copy link

@joshgoebel joshgoebel commented Oct 31, 2020


Just realized we only need the callback for the look-behind, we can use actual
regex to look-ahead.


  • Existing test coverage
  • Updated the changelog at
  • Added myself to AUTHORS.txt, under Contributors

@joshgoebel joshgoebel requested review from egor-rogov and allejo Oct 31, 2020
test/api/index.js Show resolved Hide resolved
@joshgoebel joshgoebel added the WIP label Nov 1, 2020
@joshgoebel joshgoebel removed the WIP label Nov 3, 2020
@joshgoebel joshgoebel added this to the 10.4 milestone Nov 12, 2020
Copy link

@egor-rogov egor-rogov left a comment

Looks good.
(suddenly ran out of free time, will try to catch up slowly...)

@joshgoebel joshgoebel merged commit c776c4b into highlightjs:master Nov 13, 2020
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants