Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc) Misc fixes from looking at LGTM #2852

Merged
merged 3 commits into from Nov 15, 2020
Merged

Conversation

@joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Nov 12, 2020

Changes

  • minor linting fixes
  • fix(r) fixed keywords not properly spaced
  • fix(javascript) final solid fix for runaway regex
  • fix(livescript) fix potential catastrophic backtracking

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md
  • Added myself to AUTHORS.txt, under Contributors
@joshgoebel joshgoebel requested review from allejo and egor-rogov Nov 14, 2020
@joshgoebel joshgoebel added this to the 10.4 milestone Nov 14, 2020
@joshgoebel joshgoebel added this to Remaining in 10.4 Nov 14, 2020
@joshgoebel
Copy link
Member Author

@joshgoebel joshgoebel commented Nov 14, 2020

@allejo @egor-rogov If either of you find more time I created a board of what's holding up 10.4:

https://github.com/highlightjs/highlight.js/projects/2

Copy link
Collaborator

@egor-rogov egor-rogov left a comment

Look good

@allejo
allejo approved these changes Nov 15, 2020
@joshgoebel joshgoebel force-pushed the joshgoebel:lgtm branch from 35a7333 to 73efecd Nov 15, 2020
@joshgoebel joshgoebel force-pushed the joshgoebel:lgtm branch from f63fa52 to 64280be Nov 15, 2020
@joshgoebel joshgoebel merged commit dc7a81e into highlightjs:master Nov 15, 2020
11 checks passed
11 checks passed
build (15.x)
Details
build (12.x, node)
Details
build (12.x, browser)
Details
build (12.x, browser -n)
Details
build (14.x, node)
Details
build (14.x, browser)
Details
build (14.x, browser -n)
Details
build (15.x, node)
Details
build (15.x, browser)
Details
build (15.x, browser -n)
Details
security/snyk (joshgoebel) No manifest changes detected in 1 project
Details
@joshgoebel joshgoebel deleted the joshgoebel:lgtm branch Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
10.4
Remaining
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.