Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) eslint --fix against most grammars #2853

Merged
merged 7 commits into from Nov 17, 2020

Conversation

joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Nov 12, 2020

Closes #2854.

Changes

  • Runs eslint --fix on all grammars that have no outstanding PRs
  • Add markup test for every language (to regression test this and more importantly the coming changes) - #2862 needs to be merged first and then this rebase

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md
  • Added myself to AUTHORS.txt, under Contributors

@joshgoebel joshgoebel changed the title (chore) eslint --fix A-C (chore) eslint --fix against most grammars Nov 12, 2020
@joshgoebel joshgoebel requested review from allejo and egor-rogov Nov 13, 2020
@joshgoebel
Copy link
Member Author

@joshgoebel joshgoebel commented Nov 13, 2020

This was mostly automated work with just some tiny manual cleanups.

@joshgoebel joshgoebel self-assigned this Nov 15, 2020
Copy link
Collaborator

@egor-rogov egor-rogov left a comment

OK
(I haven't look through all the changes, just several files)

@joshgoebel joshgoebel merged commit f0c4a36 into highlightjs:master Nov 17, 2020
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants