Skip to content

Commit

Permalink
Fixed Highstock issue with stacks not being properly cleared when mov…
Browse files Browse the repository at this point in the history
…ing between non-grouped and grouped data, leaving artefacts in a stacked area chart. Closes #1651.
  • Loading branch information
TorsteinHonsi committed Sep 27, 2013
1 parent 3ce48f8 commit 9607afd
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 12 deletions.
5 changes: 1 addition & 4 deletions js/highcharts.src.js
Expand Up @@ -7710,10 +7710,7 @@ Axis.prototype = {
// reset stacks
if (!axis.isXAxis) {
for (type in stacks) {
for (i in stacks[type]) {
stacks[type][i].total = null;
stacks[type][i].cum = 0;
}
delete stacks[type];
}
}

Expand Down
5 changes: 1 addition & 4 deletions js/highstock.src.js
Expand Up @@ -7710,10 +7710,7 @@ Axis.prototype = {
// reset stacks
if (!axis.isXAxis) {
for (type in stacks) {
for (i in stacks[type]) {
stacks[type][i].total = null;
stacks[type][i].cum = 0;
}
delete stacks[type];
}
}

Expand Down
5 changes: 1 addition & 4 deletions js/parts/Axis.js
Expand Up @@ -1288,10 +1288,7 @@ Axis.prototype = {
// reset stacks
if (!axis.isXAxis) {
for (type in stacks) {
for (i in stacks[type]) {
stacks[type][i].total = null;
stacks[type][i].cum = 0;
}
delete stacks[type];
}
}

Expand Down

2 comments on commit 9607afd

@kishan-sanghani
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After doing the above change in highstock.src.js or using the above highstock.src.js still does not solve the problem #2351 #2336. + the scrollbar does not work properly.

http://jsfiddle.net/krishen/47cuA/1/

@TorsteinHonsi
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the latest code from GitHub your example looks okay: http://jsfiddle.net/highcharts/47cuA/2/

Please sign in to comment.