New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
when min option is set for datetime axis and min value is exactly divisible by day, the format given in dateTimeLabelFormats is not respected. #1649
Comments
Hi, The above provided patch fixed the min issue.. but it doesn't fix all issues..
|
Also, the pull request #1616 contains fixes for multiple bugs.. But it has been closed.. |
Please reopen the issue.. |
Yes I suspected that one coming... By moving the check for higherRanks to before the time is added, we miss higherRanks for the max value. But under any circumstance, the min value is more important in this regard. I don't think it's a good idea to actually change the min and max - it may have unforeseen consequences. Like in your first pull request, but substracting 1 from the min, it would break an axis that were showing actual milliseconds.
The other issue was your request on individual formatters for each series. We haven't acknowledged this as a bug. One thing is that the formatter in many cases applies to multiple series (when tooltip.shared is true). Another thing is that you can already taylor the formatter for each series by checking for the series name or similar within the formatter. |
does changing the condition 'time < max' to 'time <= max' break the things? by changing, it will work for max value which is divisible by date atleast. yes, it's good catch.. i missed the milliseconds part.. i wonderi if higherRanks array is required at all? can't we directly check whether it's divisible by day/hour/.. while plotting the labels itself? |
The text was updated successfully, but these errors were encountered: