Finish linting, except for unused local variables #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccalluc
commented
May 30, 2019
| @@ -35,11 +35,6 @@ def aggregate(): | |||
| pass | |||
|
|
|||
|
|
|||
| def store_meta_data(cursor, zoom_step, max_length, assembly, chrom_names, | |||
| chrom_sizes, tile_size, max_zoom, max_width, header=[]): | |||
| print("chrom_names:", chrom_names) | |||
There was a problem hiding this comment.
store_meta_data is redefined below.
mccalluc
commented
May 30, 2019
| default=None) | ||
| def multivec(filepath, output_file, assembly, tile_size, chromsizes_filename, starting_resolution, method, row_infos_filename): | ||
| _multivec(filepath, output_file, assembly, tile_size, | ||
| chromsizes_filename, starting_resolution, method, row_infos_filename) |
There was a problem hiding this comment.
multivec is redefined below
mccalluc
commented
May 30, 2019
| @@ -24,7 +24,7 @@ def get_2d_tileset_info(db_file): | |||
| return tileset_info | |||
|
|
|||
|
|
|||
| def get_1D_tiles(db_file, tile_ids): | |||
| def get_1D_tiles(db_file, zoom, tile_x_pos, numx): | |||
There was a problem hiding this comment.
zoom is referenced below, and the doc string suggests zoom is the second parameter.
|
Pete said to go ahead and merge. Hope to get more eyes on this before we make a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What was changed in this pull request?
Checklist