Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up commented out lines in tests #456

Open
43 tasks
mccalluc opened this issue Dec 4, 2018 · 0 comments
Open
43 tasks

Clean up commented out lines in tests #456

mccalluc opened this issue Dec 4, 2018 · 0 comments

Comments

@mccalluc
Copy link
Collaborator

mccalluc commented Dec 4, 2018

When lines are commented out in tests, it's unclear whether there's a regression, a bug we're intending to fix, or something we would just like to work in the future.

for TEST in `grep -l '//.*;' test/* | grep -v HiGlassComponentTest.js`; do git blame --show-name --show-number --date=short $TEST | grep '//.*;' | perl -ne 'chomp; print "- [ ] `$_`\n"'; done
  • 43e4f664 test/APITests.js 63 (Peter Kerpedjiev 2018-12-03 63) // expect(Object.keys(component.viewHeaders).length).toBeGreaterThan(0);
  • 43e4f664 test/APITests.js 86 (Peter Kerpedjiev 2018-12-03 86) // expect(Object.keys(component.viewHeaders).length).toBeGreaterThan(0);
  • f9801a5e test/APITests.js 61 (Peter Kerpedjiev 2018-10-19 335) // const div = global.document.createElement('div');
  • f9801a5e test/APITests.js 62 (Peter Kerpedjiev 2018-10-19 336) // global.document.body.appendChild(div);
  • f9801a5e test/APITests.js 64 (Peter Kerpedjiev 2018-10-19 338) // const api = viewer(div, simpleCenterViewConfig, { a: 'x' });
  • f9801a5e test/APITests.js 66 (Peter Kerpedjiev 2018-10-19 340) // api.setViewConfig(simpleCenterViewConfig);
  • f9801a5e test/APITests.js 67 (Peter Kerpedjiev 2018-10-19 341) // api.setAuthHeader('blah');
  • f9801a5e test/APITests.js 70 (Peter Kerpedjiev 2018-10-19 344) // const div1 = global.document.createElement('div');
  • f9801a5e test/APITests.js 71 (Peter Kerpedjiev 2018-10-19 345) // global.document.body.appendChild(div1);
  • f9801a5e test/APITests.js 73 (Peter Kerpedjiev 2018-10-19 347) // const api1 = viewer(div1, simpleCenterViewConfig, { a: 'y' });
  • f9801a5e test/APITests.js 74 (Peter Kerpedjiev 2018-10-19 348) // api1.setAuthHeader('wha');
  • f9801a5e test/APITests.js 81 (Peter Kerpedjiev 2018-10-19 352) // });
  • 416866a1 test/AddAndRemoveViewconfTests.js 37 (Peter Kerpedjiev 2018-10-16 40) // console.log('done');
  • 416866a1 test/AddAndRemoveViewconfTests.js 38 (Peter Kerpedjiev 2018-10-16 41) // done();
  • 416866a1 test/AddAndRemoveViewconfTests.js 39 (Peter Kerpedjiev 2018-10-16 42) // });
  • 416866a1 test/AddAndRemoveViewconfTests.js 41 (Peter Kerpedjiev 2018-10-16 44) // ([div, hgc] = mountHGComponent(div, hgc, 'http://higlass.io/api/v1/viewconfs/?d=default', done));
  • 416866a1 test/AddAndRemoveViewconfTests.js 46 (Peter Kerpedjiev 2018-10-16 49) viewConf.trackSourceServers = ['http://blah'];
  • 416866a1 test/AddAndRemoveViewconfTests.js 48 (Peter Kerpedjiev 2018-10-16 51) // const p = api.setViewConfig(viewConf);
  • 416866a1 test/AddAndRemoveViewconfTests.js 52 (Peter Kerpedjiev 2018-10-16 55) expect(newViewConf.trackSourceServers[0]).to.eql('http://blah');
  • 43e4f664 test/AddTrackTests.js 65 (Peter Kerpedjiev 2018-12-03 65) tilesetFinder.handleSelectedOptions(['http://higlass.io/api/v1/CQMd6V_cRw6iCI_-Unl3PQ']);
  • 43e4f664 test/AddTrackTests.js 68 (Peter Kerpedjiev 2018-12-03 68) tilesetFinder.props.onDoubleClick(tilesetFinder.state.options['http://higlass.io/api/v1/CQMd6V_cRw6iCI_-Unl3PQ']);
  • 43e4f664 test/AddTrackTests.js 85 (Peter Kerpedjiev 2018-12-03 85) tilesetFinder.handleSelectedOptions(['http://higlass.io/api/v1/TO3D5uHjSt6pyDPEpc1hpA', 'http://higlass.io/api/v1/Nn8aA4qbTnmaa-oGGbuE-A']);
  • 43e4f664 test/AddTrackTests.js 109 (Peter Kerpedjiev 2018-12-03 109) 'http://higlass.io/api/v1/GUm5aBiLRCyz2PsBea7Yzg']);
  • 43e4f664 test/AddTrackTests.js 118 (Peter Kerpedjiev 2018-12-03 118) 'http://higlass.io/api/v1/GGKJ59R-RsKtwgIgFohOhA']);
  • 43e4f664 test/AddTrackTests.js 132 (Peter Kerpedjiev 2018-12-03 132) // atm.unmount();
  • 43e4f664 test/AddTrackTests.js 134 (Peter Kerpedjiev 2018-12-03 134) // hgc.update();
  • 9dbefa4b test/AxisTests.js 41 (Peter Kerpedjiev 2018-11-25 41) // make sure we don't find any scientific notation;
  • 9dbefa4b test/AxisTests.js 54 (Peter Kerpedjiev 2018-11-25 54) // make sure we don't find any scientific notation;
  • 2d8b2d3d test/HiGlassComponentCreationTests.js 25 (Peter Kerpedjiev 2018-10-15 26) ([div, hgc] = mountHGComponent(div, hgc, 'http://higlass.io/api/v1/viewconfs/?d=default', done));
  • 39d15125 test/OSMTests.js 65 (Peter Kerpedjiev 2018-10-25 61) // const div = global.document.createElement('div');
  • 39d15125 test/OSMTests.js 66 (Peter Kerpedjiev 2018-10-25 62) // global.document.body.appendChild(div);
  • 39d15125 test/OSMTests.js 68 (Peter Kerpedjiev 2018-10-25 64) // const api = viewer(div, simpleCenterViewConfig, { a: 'x' });
  • 39d15125 test/OSMTests.js 70 (Peter Kerpedjiev 2018-10-25 66) // api.setViewConfig(simpleCenterViewConfig);
  • 39d15125 test/OSMTests.js 71 (Peter Kerpedjiev 2018-10-25 67) // api.setAuthHeader('blah');
  • 39d15125 test/OSMTests.js 74 (Peter Kerpedjiev 2018-10-25 70) // const div1 = global.document.createElement('div');
  • 39d15125 test/OSMTests.js 75 (Peter Kerpedjiev 2018-10-25 71) // global.document.body.appendChild(div1);
  • 39d15125 test/OSMTests.js 77 (Peter Kerpedjiev 2018-10-25 73) // const api1 = viewer(div1, simpleCenterViewConfig, { a: 'y' });
  • 39d15125 test/OSMTests.js 78 (Peter Kerpedjiev 2018-10-25 74) // api1.setAuthHeader('wha');
  • 39d15125 test/OSMTests.js 85 (Peter Kerpedjiev 2018-10-25 79) // });
  • c285469d test/search_field_test.js 36 (mccalluc 2018-11-13 37) // expect(range1).to.eql([1, 249250621]);
  • c285469d test/search_field_test.js 37 (mccalluc 2018-11-13 38) // expect(range2).to.eql([249250622,492449994]);
  • c285469d test/search_field_test.js 61 (mccalluc 2018-11-13 62) // expect(range1).to.eql([1, 249250621]);
  • c285469d test/search_field_test.js 62 (mccalluc 2018-11-13 63) // expect(range2).to.eql([249250622,492449994]);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant