paolo fragomeni
paolo fragomeni
hij1nx commented on pull request asyncly/EventEmitter2#141
hij1nx commented on issue asyncly/EventEmitter2#136
paolo fragomeni

Also, I kind of find using env vars in this lib sort of odd. This library is meant to be used on the client and server.

hij1nx commented on issue asyncly/EventEmitter2#136
paolo fragomeni

The PR looks fine (with the console statements removed) Do we have some kind of data to show that this adds value? Even just a test that shows 1. T…

hij1nx commented on pull request asyncly/EventEmitter2#141
paolo fragomeni

Also, would you be interested in becoming a maintainer on this project?

hij1nx commented on pull request asyncly/EventEmitter2#141
paolo fragomeni

Yeah. But honestly my head is not in this project. What about an option for this behavior so we don't break anything?

hij1nx commented on pull request rvagg/node-level-ttl#31
paolo fragomeni

that looks nice!

hij1nx commented on pull request asyncly/EventEmitter2#141
paolo fragomeni

This looks good, i wonder what it would break though in existing code if suddenly the first value was the event.

paolo fragomeni
hij1nx merged pull request asyncly/EventEmitter2#145
paolo fragomeni
Check type of `obj` in recursivelyGarbageCollect
1 commit with 1 addition and 1 deletion
paolo fragomeni
`warned` flag causes recursivelyGarbageCollect to error
hij1nx commented on issue hij1nx/levelui#41
paolo fragomeni

Open to a fix/PR for dealing with this.

hij1nx commented on issue hij1nx/levelui#41
paolo fragomeni

Ah, actually, it should be using the latest version of atom-shell, but the atom-shell module is still referencing an older version of atom-shell. I…

paolo fragomeni
licence request
hij1nx commented on issue asyncly/EventEmitter2#143
paolo fragomeni

ok, well sounds great! no worries about the license :)

hij1nx commented on issue asyncly/EventEmitter2#143
paolo fragomeni

lol, not github submodules. I don't know what a .pland file is, or how your project works, but i'm talking about commonJS/ES modules

hij1nx commented on issue asyncly/EventEmitter2#143
paolo fragomeni

My main concern is for you :) I'm concerned that if you don't use it as a module you will find it quite painful to maintain your library. Any reason

hij1nx starred jed/skeyma
hij1nx starred radare/sdb
hij1nx starred adrai/enum
hij1nx commented on issue asyncly/EventEmitter2#142
paolo fragomeni

Hmm, my immediate reaction is -1 on this idea because it makes the API surface area larger, it's also a pretty unique use case. If onAny could be u…

hij1nx commented on issue asyncly/EventEmitter2#139
paolo fragomeni

Open to a PR that makes the first arg the event. On Friday, February 20, 2015, fresheneesz notifications@github.com wrote: There's a problem with …

paolo fragomeni
  • paolo fragomeni 6f2b0f2
    various tweaks putting the UI together
paolo fragomeni
  • paolo fragomeni 83cb5a1
    fixes a case where there is a malformed level