Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

空の LineComment でエラーが発生する #9

Closed
chitoku-k opened this issue Oct 11, 2020 · 2 comments · Fixed by #33
Closed

空の LineComment でエラーが発生する #9

chitoku-k opened this issue Oct 11, 2020 · 2 comments · Fixed by #33
Labels
bug Something isn't working

Comments

@chitoku-k
Copy link
Collaborator

:GoshitekiLineComment を使ったあとにバッファーを終了すると空のコメントがレビューステートに残ってしまい、:GoshitekiComment に失敗してしまう
@chitoku-k chitoku-k added the bug Something isn't working label Oct 12, 2020
@himanoa
Copy link
Owner

himanoa commented Oct 13, 2020

catでファイル除いて空だったら追加しないみたいな実装をすればいい気がしてきた！

@chitoku-k
Copy link
Collaborator Author

[[ -s filename ]] で終わり！ｗ

@himanoa himanoa mentioned this issue Oct 22, 2020
Merged
himanoa added a commit that referenced this issue Oct 22, 2020
@himanoa
Merge pull request #33 from himanoa/#9
d03c1f7 
Fix a bug where store empty body review in state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a bug where store empty body review in state himanoa/goshiteki
2 participants
@chitoku-k @himanoa