New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types: get rid of mzero #23

Merged
merged 1 commit into from May 30, 2015

Conversation

Projects
None yet
3 participants
@glasserc
Contributor

glasserc commented Mar 2, 2015

This is my attempt at solving himura/twitter-types#21. The behavior of mzero isn't super optimal and maybe there's a better, more general way to fix it, but I don't know of any, so this workaround just replaces all the mzero error messages with something a little more informative.

Types: get rid of mzero
When we hit one of these cases, the user just gets an "mzero" error
message, which doesn't help the developer at all. Replace those errors
with more helpful error messages explaining what was being parsed and
how it went wrong.

These error messages probably represent bugs in the library, so it's OK
if they aren't completely informative. A client developer probably won't
be able to do anything with them anyhow.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 2, 2015

Coverage Status

Coverage remained the same at 76.6% when pulling f1b8a22 on glasserc:no-mzero into 97f8f00 on himura:master.

coveralls commented Mar 2, 2015

Coverage Status

Coverage remained the same at 76.6% when pulling f1b8a22 on glasserc:no-mzero into 97f8f00 on himura:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 2, 2015

Coverage Status

Coverage remained the same at 76.6% when pulling f1b8a22 on glasserc:no-mzero into 97f8f00 on himura:master.

coveralls commented Mar 2, 2015

Coverage Status

Coverage remained the same at 76.6% when pulling f1b8a22 on glasserc:no-mzero into 97f8f00 on himura:master.

himura added a commit that referenced this pull request May 30, 2015

@himura himura merged commit bca562e into himura:master May 30, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment