New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secureOptions in `https` config #178

Merged
merged 1 commit into from Dec 23, 2014

Conversation

Projects
None yet
2 participants
@willdurand
Contributor

willdurand commented Dec 22, 2014

Defaults is: constants.SSL_OP_NO_SSLv3 | constants.SSL_OP_NO_SSLv2

See: https://gist.github.com/3rd-Eden/715522f6950044da45d8

@willdurand

This comment has been minimized.

Show comment
Hide comment
Show outdated Hide outdated lib/config/defaults.js
ca: [],
secureProtocol: "SSLv23_method",
// constants.SSL_OP_NO_SSLv3 | constants.SSL_OP_NO_SSLv2
secureOptions: 33554432 | 16777216

This comment has been minimized.

@dmp42

dmp42 Dec 23, 2014

Member

Why not use constants.SSL_OP_NO_SSLvX instead of the values?

@dmp42

dmp42 Dec 23, 2014

Member

Why not use constants.SSL_OP_NO_SSLvX instead of the values?

Add secureOptions in `https` config
Defaults is: constants.SSL_OP_NO_SSLv3 | constants.SSL_OP_NO_SSLv2

See: https://gist.github.com/3rd-Eden/715522f6950044da45d8
@willdurand

This comment has been minimized.

Show comment
Hide comment
@willdurand

willdurand Dec 23, 2014

Contributor

@dmp42 fixed the patch to use constants, and rebased.

Contributor

willdurand commented Dec 23, 2014

@dmp42 fixed the patch to use constants, and rebased.

@dmp42

This comment has been minimized.

Show comment
Hide comment
@dmp42

dmp42 Dec 23, 2014

Member

Thanks a lot!
Let travis build and merged this.

Member

dmp42 commented Dec 23, 2014

Thanks a lot!
Let travis build and merged this.

@willdurand

This comment has been minimized.

Show comment
Hide comment
@willdurand

willdurand Dec 23, 2014

Contributor

LGTM from Travis POV :p

Contributor

willdurand commented Dec 23, 2014

LGTM from Travis POV :p

dmp42 added a commit that referenced this pull request Dec 23, 2014

Merge pull request #178 from willdurand/secure-options
Add secureOptions in `https` config

@dmp42 dmp42 merged commit b1de0da into hipache:master Dec 23, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@dmp42

This comment has been minimized.

Show comment
Hide comment
@dmp42

dmp42 Dec 23, 2014

Member

Merged :)

Member

dmp42 commented Dec 23, 2014

Merged :)

@willdurand willdurand deleted the willdurand:secure-options branch Dec 23, 2014

@willdurand

This comment has been minimized.

Show comment
Hide comment
@willdurand

willdurand Dec 23, 2014

Contributor

thanks!

Contributor

willdurand commented Dec 23, 2014

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment