Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secureOptions in https config #178

Merged
merged 1 commit into from Dec 23, 2014
Merged

Add secureOptions in https config #178

merged 1 commit into from Dec 23, 2014

Conversation

@willdurand
Copy link
Contributor

@willdurand willdurand commented Dec 22, 2014

Defaults is: constants.SSL_OP_NO_SSLv3 | constants.SSL_OP_NO_SSLv2

See: https://gist.github.com/3rd-Eden/715522f6950044da45d8

@willdurand
Copy link
Contributor Author

@willdurand willdurand commented Dec 23, 2014

ca: [],
secureProtocol: "SSLv23_method",
// constants.SSL_OP_NO_SSLv3 | constants.SSL_OP_NO_SSLv2
secureOptions: 33554432 | 16777216
Copy link
Member

@dmp42 dmp42 Dec 23, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use constants.SSL_OP_NO_SSLvX instead of the values?

Defaults is: constants.SSL_OP_NO_SSLv3 | constants.SSL_OP_NO_SSLv2

See: https://gist.github.com/3rd-Eden/715522f6950044da45d8
@willdurand
Copy link
Contributor Author

@willdurand willdurand commented Dec 23, 2014

@dmp42 fixed the patch to use constants, and rebased.

@dmp42
Copy link
Member

@dmp42 dmp42 commented Dec 23, 2014

Thanks a lot!
Let travis build and merged this.

@willdurand
Copy link
Contributor Author

@willdurand willdurand commented Dec 23, 2014

LGTM from Travis POV :p

dmp42 added a commit that referenced this issue Dec 23, 2014
Add secureOptions in `https` config
@dmp42 dmp42 merged commit b1de0da into hipache:master Dec 23, 2014
1 check passed
@dmp42
Copy link
Member

@dmp42 dmp42 commented Dec 23, 2014

Merged :)

@willdurand willdurand deleted the secure-options branch Dec 23, 2014
@willdurand
Copy link
Contributor Author

@willdurand willdurand commented Dec 23, 2014

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants