Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid HipChat message restrictions by converting all applicable characte... #21

Closed
wants to merge 1 commit into from

Conversation

@barraponto
Copy link

@barraponto barraponto commented Jul 16, 2012

...rs to HTML entities.

I found this limitation when trying to post a message with the format User Name <email@something.com>.
This simple patch fixes that.

@barraponto barraponto closed this Jul 16, 2012
@barraponto
Copy link
Author

@barraponto barraponto commented Jul 16, 2012

Turns out this is dangerous if any client already escapes the message. The proper way to handle this would be to set the message format to text, since it is considered HTML by default (thus email@something.com is properly stripped). See https://github.com/mojotech/hipchat/pull/19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.