Avoid HipChat message restrictions by converting all applicable characte... #21

Closed
wants to merge 1 commit into
from

Projects

None yet

1 participant

@barraponto

...rs to HTML entities.

I found this limitation when trying to post a message with the format User Name <email@something.com>.
This simple patch fixes that.

@barraponto barraponto closed this Jul 16, 2012
@barraponto

Turns out this is dangerous if any client already escapes the message. The proper way to handle this would be to set the message format to text, since it is considered HTML by default (thus email@something.com is properly stripped). See https://github.com/mojotech/hipchat/pull/19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment