require json in spec_helper #61

Merged
merged 1 commit into from Jan 24, 2014

Conversation

Projects
None yet
3 participants
Contributor

ktdreyer commented Dec 28, 2013

When running the tests outside of rake or bundler (for example, during RPM packaging), the tests fail because we don't require the json gem before calling to_json.

Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.vwpgPn
+ umask 022
+ cd /builddir/build/BUILD
~/build/BUILD/hipchat-1.0.1/usr/share/gems/gems/hipchat-1.0.1 ~/build/BUILD/hipchat-1.0.1
+ cd hipchat-1.0.1
+ pushd ./usr/share/gems/gems/hipchat-1.0.1
+ rspec -Ilib spec
DEPRECATION: RSpec::Core::Configuration#backtrace_clean_patterns is deprecated. Use RSpec::Core::Configuration#backtrace_exclusion_patterns instead. Called from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require'.
.......................FFFFFFFFFFF.F..
Failures:
  1) HipChat#topic (API v2) is successful without custom options
     Failure/Error: mock_successful_topic_change("Nice topic")
     NoMethodError:
       undefined method `to_json' for {:room_id=>"Hipchat", :from=>"API", :topic=>"Nice topic"}:Hash
     # ./spec/shared_hipchat.rb:66:in `mock_successful_topic_change'
     # ./spec/hipchat_spec.rb:183:in `block (3 levels) in <top (required)>'
@ktdreyer ktdreyer require json in spec_helper
When running the tests outside of rake or bundler, the tests fail
because we don't require the json gem before calling `to_json`.
138103e

Coverage Status

Coverage remained the same when pulling 138103e on ktdreyer:spec-json into b57e24e on hipchat:master.

@zsiddique zsiddique added a commit that referenced this pull request Jan 24, 2014

@zsiddique zsiddique Merge pull request #61 from ktdreyer/spec-json
require json in spec_helper
4db8aac

@zsiddique zsiddique merged commit 4db8aac into hipchat:master Jan 24, 2014

1 check passed

default The Travis CI build passed
Details

ktdreyer deleted the ktdreyer:spec-json branch Nov 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment