Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to node-expat 2.0.0 #71

Closed
wants to merge 1 commit into from

Conversation

justinrainbow
Copy link

The 2.0.0 version of node-expat bundles the libexpat dependency (xmppo/node-expat#48) which makes it easier for both Windows / Unix users to get node-expat installed.

Here's a link to the full diff between node-expat v1.6.1 and v2.0.0 - xmppo/node-expat@v1.6.1...v2.0.0

The 2.0.0 version of node-expat bundles the libexpat dependency (xmppo/node-expat#48) which makes it easier for both Windows / Unix users to get node-expat installed.
@powdahound
Copy link
Contributor

Last time I tried this there were some incompatibilities. Did you verify that this works?

@justinrainbow
Copy link
Author

Yup, I've been running it with the latest version of Hubot and haven't run in to any issues yet.

@powdahound
Copy link
Contributor

Are you on Heroku? It was failing to build there previously; #46

@laurentkempe
Copy link

I just installed it on my Windows 8 64bits machine running node v0.10.5 and could connect hubot to our hipchat rooms without any issue!

With v1.6.1 you get a compilation error as the one discussed there xmppjs/ltx#16

@rbergman
Copy link
Contributor

I'm not sure why we had node-expat in the hubot-hipchat package.json, but it doesn't seem to be required there any more and has therefore been removed. Both ltx and node-xmpp declare their node-expat dependencies such that they result in 2.0.0 being brought in with a fresh hubot-hipchat installation now. Since they are the only hubot-hipchat dependencies that in turn require node-expat, it looks like this issue is obsolete.

@rbergman rbergman closed this May 14, 2013
@egordon egordon mentioned this pull request Jun 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants